libbpf-tools: add CO-RE 'pidpersec' #4963
Open
+151
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a CO-RE port of the Brendan Gregg's pidpersec BCC Python tool.
myhro
requested review from
brendangregg,
goldshtn,
davemarchevsky,
drzaeus77,
yonghong-song and
4ast
as code owners
|
Thanks for contribution. But bcc tools are used for production debugging and observations. You need to provide real use cases for the tool to be merged. |
|
Thanks for the feedback, @yonghong-song. This PR is not a completely new addition, but a C/libbpf port of the existing My understanding is that if a tool is already part of the repository, it's considered useful for production debugging/observations. Maybe this case is different, considering it was added ~9 years ago, and it was just a showcase of BPF functionality back then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a CO-RE port of the Brendan Gregg's
pidpersecBCC Python tool.It's my second attempt in porting a BCC tool to CO-RE. I'm starting from the smaller ones, but the intention is to eventually get to the larger ones.